Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter fixes on redshift schema group #43

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Linter fixes on redshift schema group #43

wants to merge 8 commits into from

Conversation

raymondberg
Copy link

Problem

The linter fails on master and blocks builds. 😢

> make build
==> Checking that code complies with gofmt requirements...         
gofmt needs running on the following files:                            
./redshift/resource_redshift_schema_group_privilege.go                 
You can use the command: `make fmt` to reformat code. 
make: *** [GNUmakefile:28: fmtcheck] Error 1

Solution

Run the linter! 😄

coopergillan
coopergillan approved these changes Feb 4, 2021
View reviewed changes
Copy link

@coopergillan coopergillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧧

This was referenced Feb 4, 2021
Open
Open
Merged
raymondberg and others added 7 commits February 4, 2021 15:04
@raymondberg
Merge pull request frankfarrell#1 from raymondberg/master
1ed0165 
Linter fixes on redshift schema group
@raymondberg
Add support for terraform 0.12
e1541b4
@raymondberg
Improve version tooling
5ebc8c8
@raymondberg
Don't include binaries in version control
1180b37 
__Problem__

The binaries directory grows by a few dozen MB every release, keeping
these checked in as code is not ideal for developers or users.

__Solution__

Add a .gitignore and rely on copies included in tag releases.
@raymondberg
Bump to version 1.0.0
c4541c2
Add support for goreleaser
13d77ac
Add docs for publishing to the registry
3abdfda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coopergillan coopergillan coopergillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondberg @coopergillan